Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update peerDependencies tslib and rm @fluentui/react-theme-provider dependency #2940

Merged
merged 2 commits into from
Nov 8, 2024
Merged

update peerDependencies tslib and rm @fluentui/react-theme-provider dependency #2940

merged 2 commits into from
Nov 8, 2024

Conversation

wanghoppe
Copy link
Member

@wanghoppe wanghoppe commented Nov 7, 2024 •
edited
Loading

No description provided.

@wanghoppe wanghoppe changed the title update peerDependencies tslib requirement and rm @fluentui/react-them… update peerDependencies tslib and rm @fluentui/react-theme-provider dependency Nov 8, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.34%. Comparing base (d632200) to head (76a03c0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #2940   +/-   ##
=======================================
  Coverage   80.34%   80.34%           
=======================================
  Files        1505     1505           
  Lines       48800    48800           
  Branches     6026     6074   +48     
=======================================
  Hits        39206    39206           
  Misses       9406     9406           
  Partials      188      188
Files with missing lines Coverage Δ
packages/bonito-ui/src/theme/theme-util.ts 26.98% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d632200...76a03c0. Read the comment docs.

ReneOv-MSFT
ReneOv-MSFT approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@ReneOv-MSFT ReneOv-MSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! ✅

@wanghoppe wanghoppe merged commit d257049 into main Nov 8, 2024
8 checks passed
@wanghoppe wanghoppe deleted the hoppe/update-tslib branch November 8, 2024 20:24
@gingi gingi mentioned this pull request Nov 20, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ReneOv-MSFT ReneOv-MSFT ReneOv-MSFT approved these changes

@cRui861 cRui861 Awaiting requested review from cRui861 cRui861 is a code owner

@dpwatrous dpwatrous Awaiting requested review from dpwatrous dpwatrous is a code owner

@gingi gingi Awaiting requested review from gingi gingi is a code owner

@zfengms zfengms Awaiting requested review from zfengms zfengms is a code owner

@wiboris wiboris Awaiting requested review from wiboris wiboris is a code owner

@skapur12 skapur12 Awaiting requested review from skapur12 skapur12 is a code owner

@NickKouds NickKouds Awaiting requested review from NickKouds NickKouds is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wanghoppe @ReneOv-MSFT